[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] hvmloader: do not include system headers for type declarations
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 24 Feb 2021 13:20:09 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ok12U9rxEGFwWYAsm8WBJ89Xf072quc4MNURba2/bAs=; b=BcFykGl8OnVmAqjXyuy7Anc+EwObfDAJ/JwKX5AsC5ic0rLDoHgk35h88mqHDx7qPR++sQ2z2NnC/JVnMvGCaniUjXv/dfqRFb4kQGcSTFU2+OelgOjl6WrnZ5nOuIv9s2clr9InzVIeyNvRMyFeYGxf//1TeRyplbHUbG87jix/t3A/z3771O3sDDM1Izj4UyBncaNvcOVqAQEW0XPAbsx0kb5pM9ICZ1qR7fZFD9BMdoz8FzKUpPoc5HUkcv4+GoQoCBa4a1PasaIczbc4AldQzMT/eB5Xbxp/TSVrrt0utoR/0uC/4lyWacMCcfuwX2TatsK7vMlHuHgFEbJmHg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GnhuUWrFmO+wMOiTtmqRFMes7++2U7GM3aiqvqeLxflZeXS/34oXl67wqLso485qwmQrKntqG5f6OT+c9PMxuy7SGjjaMLvdvqg1yiVLU/qvMs2b5THQx5oD/eT1H9swInHS5Dus+uLT2d4/bG6kip/yoIynkaRKPGaoAI1MMlbvxJNcld0TxvsMJC18IXW0LiYu17/2QYR2alsKRzaRpoEyijfRMTBQ3/ZkvT1fNweAIPH27z9ct8uF2J7CgFOtCvQsWbdaK4mvU7JU7cdoB6xSRcczfFku3+9YsBfVDNdqYCfjK1KZiW0zXFJx4QIImq/ujmo3Y0uKFiy9sCT/Mw==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
- Delivery-date: Wed, 24 Feb 2021 12:20:26 +0000
- Ironport-sdr: Qlx1dVVS2khDOSVX6Fl2AuMOzuSYdTyq8Ymeg7zCWkJNpUiUR2sChmW6L6UfAXNvGfTqDvi0jD RybzboO33BPU2WxGH8ZLxvKsyK131Hd9qMzmTeFfYTVOH7klJTCwM6qAm4U2c5wPurVFlAACvm Zt3ECG3yajEJZef0Ipltl4tCxMaQrh13Joo+wyaOYZkoRzeKz2hxp1TFnuMGysoEdmXUSw/Sxp 7F2z/CiaEHwybbq4bi0HrF0VzGlcuxeUJ/7CmFofv7jYQgNizH0rPZq3dFZOgPPbKID7twuJt6 s64=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Feb 24, 2021 at 12:11:45PM +0000, Andrew Cooper wrote:
> On 24/02/2021 10:26, Roger Pau Monne wrote:
> > Instead create a private types.h header that contains the set of types
> > that are required by hvmloader. Replace include occurrences of std*
> > headers with type.h. Note that including types.h directly is not
> > required in util.c because it already includes util.h which in turn
> > includes the newly created types.h.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> At what point do we just declare Alpine broken? These are all
> freestanding headers, an explicitly available for use, in the way we use
> them.
The headers are available in Alpine, but they seem to be specifically
tied to the native bitness of the OS, which is causing us the issues.
So they are freestanding AFAICT, it's just that the bitness they use
is not portable.
Thanks, Roger.
|
