[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] hvmloader: do not include system headers for type declarations
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 24 Feb 2021 12:11:45 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OS4744UASJ5jLuzW+p6RrPHDc6LxB2P5eZQPbwgk9CA=; b=Jp2dTaWjzO7/dTzfHFGaZbnjg+4rB24FpQK+1wPsbKCv7oQQaDbPQkUp3u3rjxVAW5c79GWbeeCmmzqW5+Mk1ld8taf4HHNJrg9a4pMMKJwN+d08hzlTZ0UIoK54ieycGIKMWoetES7+J25y2p9eMZeuBOz0IzLlzxES9YqxrYwWaQ8JjZkZWn4rJakCWWmPb7dHfU8KzT3MKjh/716uPFXd9HNxgukJpA18KWIbwn1lFX9L/vBgYmtdtHZWhqaAjES6rVT2e7dGcI/vaPET4X2ucJIT3uGZJLroF3IIvEh/vw5CP4gV1h2WeQbgevmAX0hiflyZ79TdRcorX0opeA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N9mR7T4OavRkx9qi65hu8GjXxuYAKPcc1cB/aoB3b9QITIYdtwAb0q/fAjQXzaKCYZYCmqixDqMiAlpOKt8qQ5t7Jmilfk6cpjlAm9qn2vsH3MnhdYINYbuEmURCRbrzxwWQKwnmxbz9K9E6kJd7AVSSDYl0qpQS7psU6hmC+Qo1UohJe9FKfgeC5dU4i98FyOW2yJXV71ztDhOVsC3gfiTSWyZamQiTnaSOJPBEIn/+SAnZFXiB+yFlTT7rd3ebH72I3O0X68ZYHdXX/ZolyjxqxxjA0oyh/Slh/PhqjTmRu9ddxGANXaJ2SN0h6G3vtg9G5aEhHNu1T2zXEO0Yhg==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
- Delivery-date: Wed, 24 Feb 2021 12:12:00 +0000
- Ironport-sdr: wjH4aYhOaD0d+D9uPbYohWBCjdO1J14CjCTQ65V8xlpevPi/LO5wSI79L6DpR/s1llPSKijQS2 glDDjOW38jwtQ9Ns65GuMuFEKoqArOGqW8xr0qRpMcMQmfnid47tbP2Xs7Fbfbs1Ap8eCZ7vSw T+djf96jxvx9purS2iiXXIeuH35FY5umCR0Hhz/qj3ZS6KzkKLebgGxB+BibIq6zt42cuvpFWz H1XkzKfsxcuh0tYlTPL4JZuktUGC3tD3el1z/shnTkzBy72tzZfRRXjB+FtC/qSUycjW1a361M wY0=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/02/2021 10:26, Roger Pau Monne wrote:
> Instead create a private types.h header that contains the set of types
> that are required by hvmloader. Replace include occurrences of std*
> headers with type.h. Note that including types.h directly is not
> required in util.c because it already includes util.h which in turn
> includes the newly created types.h.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
At what point do we just declare Alpine broken? These are all
freestanding headers, an explicitly available for use, in the way we use
them.
There are substantial portability costs for making changes like this,
which takes us from standards compliant C to GCC-isms-only.
~Andrew
|
