Re: [PATCH v20210209 4/4] xl: disable --debug option for xl migrate

[Olaf Hering <olaf@xxxxxxxxx>]

Am Tue, 9 Feb 2021 17:12:28 +0000
schrieb Ian Jackson <iwj@xxxxxxxxxxxxxx>:

> It seems to me that something is definitely a bug here but I want to
> understand from Andy what the best thing to do is.  I'm hesitant to
> release-ack removing this at this stage.
> 
> Wouldn't it be better to just fix the docs like in your previously
> suggested patch ?

To make that initial patch accurate, this additional change is required:

--- a/tools/libs/guest/xg_sr_save.c
+++ b/tools/libs/guest/xg_sr_save.c
@@ -752,7 +752,7 @@ static int send_domain_memory_live(struct xc_sr_context 
*ctx)
     if ( rc )
         goto out;
 
-    if ( ctx->save.debug && ctx->stream_type != XC_STREAM_PLAIN )
+    if ( ctx->save.debug )
     {
         rc = verify_frames(ctx);
         if ( rc )

Otherwise there is no way for "xl" to trigger a call into verify_frames.

I will test this patch today.


Olaf

Attachment: pgpgkLgTN6HtD.pgp
Description: Digitale Signatur von OpenPGP