[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.15 2/2] libs/foreignmem: Fix/simplify errno handling for map_resource
- To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 3 Feb 2021 17:52:58 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S1RuMOxAsejss2NVD2n4KkH0wh3MGAfBL0OKR5o0nWA=; b=QZEd4joBnvx9KZ4MIecP6PRlgbJlXmLAlFYEGPXeNYgFuj6tXDqijn8VQdJOjBlI4sLXcfCBpoQ5MBqHyArd5cZhx6JxR5A69J5ZWrqP3jo0sVqYf+d0mBeun1HGs3TUNDiCwdi+0BWXwGytlnaJ5cAJe4zCHYiBj9LvW9SPWXtGIboUOlLZqjnKKW5YUcSxAGd2ieSHPxKhGLH2xl/EzNxB6QeNNYzbZTV9SrLflVfq7ISoRNuyk2+GnisKy8OHX3L/pK0jdMEWwD1go2OnZ89XW7+7ptupX1vd80t1syVm5AEIRlBNM/OqiwlhY9Ln0CbyPRtUpjs9G6Xwea5/2A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aSX2DzvZEqudm1AArxNF4e0AcmZ5WcJUWepkDz7GLdiCE1eqcg1lMdMQjwoWF7TQqMP/ciNzHuMjpMyfSI4d9neTM6hzy8erUo3k5C0X2BnZmwYXKWeYbGYNX3HpMvhWAIWE3qhGqnUGHSxhXwHxQTMNdnK1vkaXzD9KeRZT873+hriAH8Kowv0tY702TcdTivq863lFZ13GS/O0ba4yuvxOlbxbSCDE6Z8QzgJwXH3wta2RT3+b21yJbGLVoR7ZKkXwYUWCBd51RiRHbKhFEcTX365O465DK+WWgaOjK8QwID3cmnJqO8xDlvkPDc/vsbdL7yzJsufKTRX3fhkXGg==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Manuel Bouyer <bouyer@xxxxxxxxxx>
- Delivery-date: Wed, 03 Feb 2021 17:53:39 +0000
- Ironport-sdr: 6dAi2n9oqQPgZdbf7QqYdjFl5NVlssJb0Rf9VbtOfWZF4PsNFbTtHzeFXBwfTJaRJy4ZJipFno JVWw6ocRfxJomMvug0oRCs6brfzXDlgOl5wY9ySdZIThPgtzD61bdLJ9Xb9olrYtmWnqnyhCQI lPW1ZniTbnNqanZbVjz2zl2VKNPkWyweRSdeRG5FdCGJ2SIH1iWOYYqzPLLRt8yelYTUY2xRYx e9Su5/GyPQJIfL8PA8z/BqCIXmJjrsF0ivbRsipwN4LMge4Kx3a0vLLDY6bkLPr4mCyTIK7dyn dWc=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03/02/2021 17:51, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH for-4.15 2/2] libs/foreignmem: Fix/simplify
> errno handling for map_resource"):
>> Simplify the FreeBSD logic, and duplicate it for NetBSD as the userpace ABI
>> appears to be to consistently provide EOPNOTSUPP for missing Xen/Kernel
>> support.
>>
>> The Linux logic was contorted in what appears to be a deliberate attempt to
>> skip the now-deleted logic for the EOPNOTSUPP case. Simplify it.
> Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
>
> Sorry for my earlier confusion. I had lost the context between the
> two patches. I will explain my reasoning for the R-A:
>
> For the first two hunks (freebsd.c): these are consequential cleanup
FreeBSD and Linux.
> from patch 1/2 of this series. Splitting this up made this easier to
> review and we don't want to leave the rather unfortunate constructs
> which arise from some hunks of 1/1. IOW, the combination of 1/1 plus
> the first two hunks here is definitely release-worthy and the split
> has helped review.
>
> The final hunk is a straightforward bugfix.
>
> This combination of two completely different kinds of thing is a bit
> confusing but now that I have explained it to myself I'm satisfied.
Thanks,
~Andrew
|
