[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH for-4.15 2/2] libs/foreignmem: Fix/simplify errno handling for map_resource
Andrew Cooper writes ("[PATCH for-4.15 2/2] libs/foreignmem: Fix/simplify errno handling for map_resource"): > Simplify the FreeBSD logic, and duplicate it for NetBSD as the userpace ABI > appears to be to consistently provide EOPNOTSUPP for missing Xen/Kernel > support. > > The Linux logic was contorted in what appears to be a deliberate attempt to > skip the now-deleted logic for the EOPNOTSUPP case. Simplify it. Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx> Sorry for my earlier confusion. I had lost the context between the two patches. I will explain my reasoning for the R-A: For the first two hunks (freebsd.c): these are consequential cleanup from patch 1/2 of this series. Splitting this up made this easier to review and we don't want to leave the rather unfortunate constructs which arise from some hunks of 1/1. IOW, the combination of 1/1 plus the first two hunks here is definitely release-worthy and the split has helped review. The final hunk is a straightforward bugfix. This combination of two completely different kinds of thing is a bit confusing but now that I have explained it to myself I'm satisfied. Ian.
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |