[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.15 1/2] libs/foreignmem: Drop useless and/or misleading logging
- To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 3 Feb 2021 17:26:01 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+JLhdE93bHB9SpQ6drUbuNUQHREO/ZYr9kTsziNRNYk=; b=Q1He+dBrcEn83HBdHmxBNhicRI3xUDoYGPGLzdPFNmk1pqSqOBqRK4uaNIUfklGbs5sIH9DrV17oFHviTwh5SWaAA8miSA64SXI+BS9Xtg0vyJYSCoaI+2oda+vryPS4Ur+DSJumNjTkoqg0iKdZ+QQJC1X5WlvN6mMcsi6NecMmNeN1Wk0gbhsGNWjbYXC5WSU0Oz9XsJUe0XS+g5zxE8draN22r9l+OjJd6IT3uiuyIPlqnlquIM3+jNM4mZo4/41aduIg8pv2sc/QeZrf4VYMWALBrXhNgsUZ4z1d8cE9TEP3oYQH5j8/9IJ8MTUJOBIpLnZtsD+9UcsI82wcjQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lFfDnu08iuf3HYulGPOLXa/kFbNPgV6faieoDOqqYU7PEC/JtZpCxNvXTFOr2gk+mCfmre6rQLJLTtjyqDO9b0W+h6n4WnZIm/9AUIymCQrsVuZqmB4aHzceIYCMC2HW7Cfd7ksnp+kjRy6U/EPBlexIsQFVTzRAT7oY7Kv3CUlb2r5g3xXKPUPBhrk2/g5Afj5C9HuMCK1RDFy/i+Qzi9uwG63hDthea7GcOnn2/AkkO6boE5+ZlwS2PMetPSFXh8omLrcRJDb+RJs1e4qc3Rio+eied9ea5XjF8jkZXZHAX3fIfcLJRLHXbOB7clWpIxKRSQrXtm3NNXBp4MOacg==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Manuel Bouyer <bouyer@xxxxxxxxxx>
- Delivery-date: Wed, 03 Feb 2021 17:26:19 +0000
- Ironport-sdr: tgPX8heHvBp/yqe6+MJa5PhGsaSzlq+kEs9/eNfpcsTGIO6hsAKEAnS6jVok80IijHq55lYM8B qLNdvdchY7G34jrJMljWIzUYCM8f3DvpiJsfh8fDVdVt/+SHLjEh7fnAAn5ujhiRzVZq6qZE13 kxhZZRpKoN0+DVfjmF1gXleXxFWhSz6SQLIW1sRE0gXmevoi9rsXGc5DePLAr8BnmZ6luTosXP 0CceYUnkq+fk2WNQzAIPYu/OKRmfblPThozAHdvuSMXwyhKt0G1gqq8kpHDIEcREP0lr17qnH2 X0Q=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03/02/2021 17:16, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH for-4.15 1/2] libs/foreignmem: Drop useless
> and/or misleading logging"):
>> These log lines are all in response to single system calls, and do not
>> provide
>> any information which the immediate caller can't determine themselves. It is
>> however exceedinly rude to put junk like this onto stderr, especially as
>> system call failures are not even error conditions in certain circumstances.
>>
>> The FreeBSD logging has stale function names in, and solaris shouldn't have
>> passed code review to start with.
>>
>> No functional change.
> Thanks.
>
> Reviewed-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
Thanks,
>
>> int saved_errno = errno;
>> - PERROR("XXXXXXXX");
>> +
> That's particularly wtf...
My thoughts exactly.
~Andrew
|
