[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: staging: unable to restore HVM with Viridian param set
- To: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 2 Feb 2021 11:55:37 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eYnZcQ6pmNweY6iauGn946d+ZuiIupbjWLAvjA6Ju5U=; b=AgxCb5zH+ZOoqqg4ZJpDDg2yGv4SNpTdJ8T03M10Qpv07DjI+oeQp0S7K4HoaIlSjwNLYY+HO/iBazx5Q1ZILXlSw16cGpDv6qp85qFxFYmvv/i3gMRhnAxBQZZ+NvdGopKWZxnj/NusRRCHfUNUIngXRy23oxMLJEwGKvFYY8MwEjSRkh5iUKnjIU9p5vKab7JBPHODtc6LIto2DLMGOlhoJbc7KxL6T3DdKS4r6qlMXnWztxWw/h4JE/HfmckJ3vcQ02pGGnhgCk5HwUhiTKH7ofo6e7Rot7ld+UKvWPtun+j2omUCmaIcyltrssf7otWpkIJOT5TbhDtfgpvYDA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hSAbLa4/+x0ErPZLXZDDR4J4h/Xyn+J2sE1yPiFY2e21cv7M0bAq3EKMRWSf7jWvcfFaAjrzWnvRE2zXuCnzDcHPIAtcbRaggdYkGYY5T4wC8NeV52Wk/k7mUINDwnkwUxJfBSUp6hmMJmulnQVpio9KQLDPvwOMk9l6KePitaDfsC8E1Wuv2hCGXe1thPOurOwsj0bkZ3tb/5z2FFB+G1WY5nnOAFOPmePel1CMW2LT2DP10cymH1NKqhIuTelvWv5oxrbpiXi/Ij7KQMlGQwG6vYsOMGzDyTMDAkj1K+ocNzwTHG0NLq6Gb47L+QE1PgXoYcegp8N7GDGVCFxo9g==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <paul@xxxxxxx>, 'Tamas K Lengyel' <tamas.k.lengyel@xxxxxxxxx>, 'Xen-devel' <xen-devel@xxxxxxxxxxxxxxxxxxxx>, 'Wei Liu' <wl@xxxxxxx>, 'Anthony PERARD' <anthony.perard@xxxxxxxxxx>
- Delivery-date: Tue, 02 Feb 2021 11:55:55 +0000
- Ironport-sdr: dqJePxJfYUpHBHVG7lu5SAgIat4XdakfuX5F0hk7W6R/zpTOrNa7SUp4Ub8OXG1FBKLCdx9LEg 10OIzzZcZvJ/bBaLD+pYsYlPrxZk3OvqwBNyHs3J0OU5V3eiNuNzgXlKU/BotPv+YSvZuwYSG6 oLKYjxDIaeRlcrZB+0t/0+SxrKHEeLVeR/fMYt9qNSaZlBUDaVfSSud274oFVjFvsCHpxOXCKC 84Ib70W9savSh0DgYQQExKU6nvJYjBobtkVnk1obxmNOn7O9Jh7ghoQLLXt6hTDhet+C/NFPr0 +3U=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02/02/2021 11:51, Ian Jackson wrote:
> Igor Druzhinin writes ("Re: staging: unable to restore HVM with Viridian
> param set"):
>> On 02/02/2021 08:35, Paul Durrant wrote:
>>> Surely it should be addressed properly in libxl by not messing with the
>>> viridian settings on migrate-in/resume, as Andrew says? TBH I thought this
>>> was already the case. There should be no problem with adding to the default
>>> set as this is just an xl/libxl concept; the param flags in Xen are always
>>> define the *exact* set of enabled enlightenments.
>> If maintainers agree with this approach I can make a patch.
> If Andy is in favour of this approach then certainly it is fine by me.
Yeah - in the case that we're restoring from a suspend image or migrate,
just skip setting the viridian flags in build. They are in the the
stream, and will be restored later.
~Andrew
P.S. This is going to get even more complicated when it all shifts into
CPUID settings, but it needs to happen at some point.
|