[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/4] hw/xen: Have Xen machines select 9pfs

On 31/01/21 15:18, Philippe Mathieu-Daudé wrote:
9pfs is not an accelerator feature but a machine one,
move the selection on the machine Kconfig (in hw/).

Signed-off-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>
  accel/Kconfig       | 1 -
  hw/i386/xen/Kconfig | 1 +
  hw/xen/Kconfig      | 1 +
  3 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/accel/Kconfig b/accel/Kconfig
index 461104c7715..b9e9a2d35b0 100644
--- a/accel/Kconfig
+++ b/accel/Kconfig
@@ -15,4 +15,3 @@ config KVM
config XEN
-    select FSDEV_9P if VIRTFS
diff --git a/hw/i386/xen/Kconfig b/hw/i386/xen/Kconfig
index ad9d774b9ea..4affd842f28 100644
--- a/hw/i386/xen/Kconfig
+++ b/hw/i386/xen/Kconfig
@@ -3,3 +3,4 @@ config XEN_FV
      default y if XEN
      depends on XEN
      select I440FX
+    select FSDEV_9P if VIRTFS
diff --git a/hw/xen/Kconfig b/hw/xen/Kconfig
index 0b8427d6bd1..825277969fa 100644
--- a/hw/xen/Kconfig
+++ b/hw/xen/Kconfig
@@ -5,3 +5,4 @@ config XEN_PV
      select PCI
      select USB
      select IDE_PIIX
+    select FSDEV_9P if VIRTFS

I think you can compile without FSDEV_9P selected? If so, this should be "imply".

If on the other hand you cannot, and that is because of some other file brought in by CONFIG_XEN, this patch shouldn't be there.

I can queue the series once you resolve this doubt.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.