[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] Document qemu-ifup on NetBSD
- To: Manuel Bouyer <bouyer@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 1 Feb 2021 09:21:58 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7s8Sdi+pp7MYe1YNRzd2LwR5pm5wnR6nkgEQQIRj1lI=; b=K5aEdlwi2zn1zHqzsKr1t/M945cnAGRomaue51aKFkY1qhgc2enz02/2iBQzCN4LApsyp/2A4X2uqmLU9JcoDkUG00kpLONP+ds5BeBlcVyA6Xyd4R7p1wdgnIfKTf0TNcsl9biSL0B9uj3AYeWldr1y4JtfeJ6i8JnRW58orbE/+n2RYs1EXfsZxTrF2SvUy0ZxjqQqFXxj9Xhk09jQG9Nmry0t3N+L279/dnghh2cIu6TQp0aSK8veSmwhQwPpDh8Ujk5NxBFbMoJNxQXcopHWkhlI1jfB0vJAtsILrL6v9PrqMqFSpYHcTjodv7qLeT6gHL8hevBBvwKp9TfS/w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IGyYJyJ8kM68BglVySDey41oIvYFsJ2SPUErF7VwJ1LbK0teN5fxJDkUBuut+iyaCwqQyAsNYwH0kRZJiMfKEtugIkRj/hgG+HixynxRHLwIXI9UzHEYM9u5kt4vGy2BjXldupHHqMPN/CoOo2I9WaqBqmBQUT1lB57J8ujvvZ6W/OYACXTa4rv+AGTfIIc45fobDx/DuiI4cYLpTQJV0y6BJlmJsHl9aS2zmCY1tU6KpYX40H3gndVFBLekReeSLTu6LPByOBtRY+4A44ogakzNytLt67rY9bYdu346kL+TGuABp52dAV3wX7hz/nbD7mnchIW97dCdX9G/5AT5Ig==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 01 Feb 2021 08:22:13 +0000
- Ironport-sdr: 85RMr02dFZ0aJKRfviJzq3Tn9ZttArdUDlyl/baJgWAHJ6E+cJaMav1gZ3LZl1LWo+AWyjKD4s xHj9lgw4Tl/1C5Cr2UdgdBqi/EhbNkxsv1G4nNfj6coXiodrYQAmMRsgQPgOxDtRBTlikZEX4C K4afBcxFg3l04uAmmiWa7jYmJR6vlJLatXdqinTEiUdzu+XKigCoe5kIeZxVVKZIYN1tOeUQo4 84FeOa+m7dVLPBDlZ94oNxDknEJXgI8+9BKiyhxDsHOoB6RQRYzDde/Zm/BT3swnV70sv/0nxn Jvg=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Sun, Jan 31, 2021 at 12:03:00AM +0100, Manuel Bouyer wrote:
> Document that on NetBSD, the tap interface will be configured by the
> qemu-ifup script. Document the arguments, and XEN_DOMAIN_ID environnement
> variable.
You are missing a Signed-off-by tag here ;).
> ---
> docs/man/xl-network-configuration.5.pod | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/docs/man/xl-network-configuration.5.pod
> b/docs/man/xl-network-configuration.5.pod
> index af058d4d3c..f6eb6c31fc 100644
> --- a/docs/man/xl-network-configuration.5.pod
> +++ b/docs/man/xl-network-configuration.5.pod
> @@ -172,6 +172,10 @@ add it to the relevant bridge). Defaults to
> C<XEN_SCRIPT_DIR/vif-bridge> but can be set to any script. Some example
> scripts are installed in C<XEN_SCRIPT_DIR>.
>
> +On NetBSD, HVM guests will always use
> +C<XEN_SCRIPT_DIR/qemu-ifup> to configure the tap interface. The first
> argument
> +is the tap interface, the second is the bridge name. the environnement
> variable
> +C<XEN_DOMAIN_ID> contains the domU's ID.
LGTM, but I would make it even less technical and more user focused:
Note on NetBSD HVM guests will ignore the script option for tap
(emulated) interfaces and always use C<XEN_SCRIPT_DIR/qemu-ifup> to
configure the interface in bridged mode.
Thanks, Roger.
|
