[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] xen/arm: Convert runstate address during hypcall
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 14 Aug 2020 09:11:35 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ORBJRNcZ9neFw5chg44OVw+UFKUZ7NrEyp7bgytOloc=; b=Ay/jcleS8yXpVeXLeMJ+WWuNcFjr0IYZ5g+hqZb0FrH4HV4XYfDnhzt6gESFMkiWbVBrXeGajDJMr3Q/b3YWOffU+MiduypdAkuRDZFM1l5jOwtTdc+n3OwroR0o4RsJyyI7FE++Aro0FTq3O8sa2MNLiW8alCZgMWH/qnQAA0KsuEzVO1poeApCvZWIq798bmoVwx/V/5//2erKuaAZHICclzbAMY7WI5NOhGgKL/vOno6rOvlmAhbp+orVt3a/i4MzULvuK/uOiwVDJnBIQcYvoCyeSWOk/FIE3xI+X91db4xsJMobrjmIYVaH93IeWi8m3ZkjFmHf0/31fgbjrw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OMb7o9bVUAjNg8UREe8osiOTVpqllkS54RozHlbcKeD2ImODpDpr0rkqYpXng+4mCasIR+pPcpjWvxAt5l//Cwx+/J+V3VlrpV1wOs2BkBsYQK5s+pnfK/ouhCew3mTP64BMpg6C0IlGvskjXqmU05ac52A7P6tHi3G4oLweNVtzdavPMij/FRQXYkAjIWLYyDSVQ0pNKJzwLxWTB1HW9AYo+MAjw6URhibLkmXWMCcC4Dhqbo4ObjjiyOqA5eUf13vhu77urak3AOBbsky2omn2Kh/R6H/nxY+wBxocpj7iG1QKBB7uGFQ+5ViXSqKKes1CqgoGLuHevR4Bl3J4Pw==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, nd <nd@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 14 Aug 2020 09:12:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWZluWPRKsKyuZRkCQVDwO60tsvakgmVkAgAEWTwCAFLPWgIABBZoA
- Thread-topic: [PATCH v3] xen/arm: Convert runstate address during hypcall
> On 13 Aug 2020, at 18:35, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Bertrand,
>
> On 31/07/2020 14:26, Bertrand Marquis wrote:
>>>> + {
>>>> + gprintk(XENLOG_WARNING, "Cannot map runstate pointer at
>>>> 0x%"PRIvaddr
>>>> + ": Invalid offset\n", vaddr);
>>>
>>> We usually enforce 80 character per lines except for format string. So it
>>> is easier to grep them in the code.
>> Ok i will fix this one and the following ones.
>> But here PRIvaddr would break any attempt to grep something in fact.
>
> The idea is you can grep a few words on the message and then easily find the
> line.
Ok i will put everything back in one line.
Regards
Bertrand
|
