[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] xen/arm: Convert runstate address during hypcall
 
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
 
- From: Julien Grall <julien@xxxxxxx>
 
- Date: Thu, 13 Aug 2020 18:35:15 +0100
 
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, nd <nd@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
 
- Delivery-date: Thu, 13 Aug 2020 17:35:30 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
Hi Bertrand,
On 31/07/2020 14:26, Bertrand Marquis wrote:
 
+    {
+        gprintk(XENLOG_WARNING, "Cannot map runstate pointer at 0x%"PRIvaddr
+                ": Invalid offset\n", vaddr);
 
We usually enforce 80 character per lines except for format string. So it is 
easier to grep them in the code.
 
 
Ok i will fix this one and the following ones.
But here PRIvaddr would break any attempt to grep something in fact.
 
 
 The idea is you can grep a few words on the message and then easily find 
the line.
Cheers,
--
Julien Grall
 
 
    
     |