[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 for-4.14] tools/libxl: fix setting altp2m param broken by 1e9bc407cf0

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Fri, 29 May 2020 17:32:24 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 29 May 2020 16:32:53 +0000
  • Ironport-sdr: cNZNwNdz9imlDuD7aarbNOnTiS4Q0578xyQsM7utOUPYSoTWOxh7HgA9JAN7O+N0wLtseKdk40 wr5wDYle/jfJAbGB/q9BO+vk+h+Fyg79TAw2BIVgnvxiXdW8RbXXKTxbsWXfytpS0s6fGShoGB gLUgIznsw6jfbpAYwu6BQ5x+QEPpduWy8MzMuyzEYqFr/Rr1DOhZpPB6cjYOxaAIgWl2qrENdq DAi+LODHzosOucNMZ3KpYzp00HobG+qNRr5kGiT72lbFBIw6QRwvHfrDkUjmTH6yQnu6a6t/pf PJs=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Andrew Cooper writes ("Re: [PATCH v2 for-4.14] tools/libxl: fix setting altp2m 
param broken by 1e9bc407cf0"):
> On 29/05/2020 17:22, Tamas K Lengyel wrote:
> > The patch 1e9bc407cf0 mistakenly converted the altp2m config option to a
> > boolean. This is incorrect and breaks external-only usecases of altp2m that
> > is set with a value of 2.
> >
> > Signed-off-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Sorry for breaking it to begin with.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

and pushed.

 

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.

Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.