[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] libxl: stop libxl_domain_info() consuming massive amounts of stack

  • To: Paul Durrant <paul@xxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Thu, 28 May 2020 16:44:51 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Paul Durrant <pdurrant@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 28 May 2020 15:45:01 +0000
  • Ironport-sdr: ql4oFMY44/0+izGe6sI3DPS766VWivHK7e+UQht1ienJumBBxINCvVrusNF/csgnzzoAXeugyh RkwXKFIBD86Pkjuj2I1aG9zb1zEiLiKk/BMNTWG/85+cXJhRlZQpqWajrLRoeSeVu6r9Xef0FV B4ldKXFF8GnjPuSq9+xelkfZFV39bwLlVzWP4Gzqc6+wKArRHm0CE4IfmDAe4zFfciS9oABf8h qpZSY4udpoySoWKrMRFmh4z29UUZ1QoZQUEtSS3znqL7frOEwE6e5YdNRFxGVH1XZaNtZD5RXr dIk=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Paul Durrant writes ("[PATCH v2] libxl: stop libxl_domain_info() consuming 
massive amounts of stack"):
> From: Paul Durrant <pdurrant@xxxxxxxxxx>
> Currently an array of 1024 xc_domaininfo_t is declared on stack. That alone
> consumes ~112k. Since libxl_domain_info() creates a new gc this patch simply
> uses it to allocate the array instead.
> Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Wei Liu <wl@xxxxxxx>
> Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> This is small and IMO it would be nice to have this in 4.14 but I'd like an
> opinion from a maintainer too.

Reviewed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

I agree that this is 4.14 material.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.