Re: [PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 21/05/2020 11:12, Paul Durrant wrote:
>> -----Original Message-----
>> From: Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of Andrew 
>> Cooper
>> Sent: 21 May 2020 10:04
>> To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
>> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Tim Deegan <tim@xxxxxxx>; Wei 
>> Liu <wl@xxxxxxx>; Jan
>> Beulich <JBeulich@xxxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> Subject: [PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p()
>>
>> When compiling with SHOPT_OUT_OF_SYNC disabled, the build fails with:
>>
>>   common.c:41:12: error: ‘sh_remove_write_access_from_sl1p’ declared 
>> ‘static’ but never defined [-
>> Werror=unused-function]
>>    static int sh_remove_write_access_from_sl1p(struct domain *d, mfn_t gmfn,
>>               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> due to an unguarded forward declaration.
> Is this, perhaps, an argument for making SHADOW_OPTIMIZATIONS tunable via 
> Kconfig so that randconfig could catch things like this?

Given enough TUITS, yes.

~Andrew