[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/3] x86: relax LDT check in arch_set_info_guest()

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 19 May 2020 11:02:20 +0200
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Tue, 19 May 2020 09:02:31 +0000
  • Ironport-sdr: IUQcCtOhP4PrdXx2PlZTuKCKevbwnBlfPV5ArJdEVGrZJd/vFqqiZkL2JhnSLazzG3KyPo0VTr hxud0AzWeWjxBLJe8LtTSVvFrZyKku2ARMPU+U4I0C7/M4wvFFrlgW+qWZlkaXES3s9ljOUzX2 8bWtYFBSDoqmPotu6/rU91AtsEs6qy4IcfvUxuwfBr2ab+csVCCUaV1N9ZDZwJyoojRRaxAa/9 D5aDYuVmteaKaiZXLZSyH5PU2/x7ik/Gb7eZRG79d4njnsBN+ABzsR9qdvcw9Nl/P9USUO+E1W Ua4=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Dec 20, 2019 at 02:50:06PM +0100, Jan Beulich wrote:
> It is wrong for us to check the base address when there's no LDT in the
> first place. Once we don't do this check anymore we can also set the
> base address to a non-canonical value when the LDT is empty.
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

I wonder if a ldt_ents check should also be added to
pv_map_ldt_shadow_page in order to avoid trying to get the mapping of
the LDT.

Thanks, Roger.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.