Re: [PATCH v8 08/12] xen: add /buildinfo/config entry to hypervisor filesystem

[Jan Beulich <jbeulich@xxxxxxxx>]

On 08.05.2020 17:34, Juergen Gross wrote:
> Add the /buildinfo/config entry to the hypervisor filesystem. This
> entry contains the .config file used to build the hypervisor.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with a remark and one further adjustment:

> @@ -73,3 +74,14 @@ obj-$(CONFIG_UBSAN) += ubsan/
>  
>  obj-$(CONFIG_NEEDS_LIBELF) += libelf/
>  obj-$(CONFIG_HAS_DEVICE_TREE) += libfdt/
> +
> +config.gz: ../.config
> +     gzip -c $< >$@
> +
> +config_data.o: config.gz
> +
> +config_data.S: $(XEN_ROOT)/xen/tools/binfile
> +     $(XEN_ROOT)/xen/tools/binfile $@ config.gz xen_config_data

This will want changing to the changed build infrastructure, such
that in default (non-verbose, non-silent) mode a line gets output
to stdout. But I'd be fine with this getting done subsequently.

> --- a/xen/include/xen/kernel.h
> +++ b/xen/include/xen/kernel.h
> @@ -100,5 +100,8 @@ extern enum system_state {
>  
>  bool_t is_active_kernel_text(unsigned long addr);
>  
> +extern const char xen_config_data;

Surely you meant to add [] here, and then possibly omit the & on
the line using the symbol?

Jan