Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly

[George Dunlap <George.Dunlap@xxxxxxxxxx>]

> On May 11, 2020, at 3:11 PM, Julien Grall <julien@xxxxxxx> wrote:
> 
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments 
> unless you have verified the sender and know the content is safe.
> 
> Hi,
> 
> On 11/05/2020 15:07, Jan Beulich wrote:
>> On 11.05.2020 15:57, Julien Grall wrote:
>>> 
>>> I have never heard of ./.config before. So what are you referring to?
>> I'm referring to this line in ./Config.mk:
>> -include $(XEN_ROOT)/.config
> 
> Great another undocumented way to do things...

Oh, is that not documented?  It’s quite venerable at this point — if it’s not 
documented that should change.  (Although I guess there’s an argument that 
everything which would be included there should be added to either KConfig or 
configure.)

I don’t think I would have thought to add XEN_CONFIG_EXPERT=y to .config to 
prevent the issue Julien is seeing.  That maybe part of the reason why this 
doesn’t bother you as much as it does him.

From a UI perspective, I think that’s a poor UI — enabling CONFIG_EXPERT from 
the menuconfig is more discoverable and more in line with what people expect.

 -George