[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly

  • To: Julien Grall <julien@xxxxxxx>
  • From: George Dunlap <George.Dunlap@xxxxxxxxxx>
  • Date: Mon, 11 May 2020 14:27:59 +0000
  • Accept-language: en-GB, en-US
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=George.Dunlap@xxxxxxxxxx; spf=Pass smtp.mailfrom=George.Dunlap@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx; dmarc=pass (p=none dis=none) d=citrix.com
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>
  • Delivery-date: Mon, 11 May 2020 14:28:16 +0000
  • Ironport-sdr: VaDVOzUPScAxQJ3TEnvE4oivfmLEbxaFnbzU8CJXilDkteVwNeahGbcwNUNHsleKuyXUONJfH0 JY4HHRs0CitcZm84amwXgGGr+6wdU5lF0hDULlb7D1gFLzWXkSyLmEudGlIKu4laGNf5UbZKPP HapQPbq7SZn+2DlURGgEaPAff5OBkmtoq4AGsfkZrO+7vxNrttUV8YxHaokJ/n/s46mjMMsfI5 VgLKhoVnJwh+RGFzgL+JaAYORGJGqASWrhJ7pvntdzy2nHnYaaOiJW8a1g0LPZDP/VAPEC1ZmC oaU=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-topic: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly

> On May 11, 2020, at 3:11 PM, Julien Grall <julien@xxxxxxx> wrote:
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments 
> unless you have verified the sender and know the content is safe.
> Hi,
> On 11/05/2020 15:07, Jan Beulich wrote:
>> On 11.05.2020 15:57, Julien Grall wrote:
>>> I have never heard of ./.config before. So what are you referring to?
>> I'm referring to this line in ./Config.mk:
>> -include $(XEN_ROOT)/.config
> Great another undocumented way to do things...

Oh, is that not documented?  It’s quite venerable at this point — if it’s not 
documented that should change.  (Although I guess there’s an argument that 
everything which would be included there should be added to either KConfig or 

I don’t think I would have thought to add XEN_CONFIG_EXPERT=y to .config to 
prevent the issue Julien is seeing.  That maybe part of the reason why this 
doesn’t bother you as much as it does him.

From a UI perspective, I think that’s a poor UI — enabling CONFIG_EXPERT from 
the menuconfig is more discoverable and more in line with what people expect.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.