Re: [Xen-devel] [PATCH 03/10] x86/gen-cpuid: Rework internal logic to ease future changes

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 27/02/2020 07:57, Jan Beulich wrote:
> On 26.02.2020 21:22, Andrew Cooper wrote:
>> Better split the logic between parse/calculate/write.  Collect the feature
>> comment by their comment character, and perform the accumulation operations 
>> in
>> crunch_numbers().
> Would you mind saying "character(s)" here, as there are items with
> multiple of them?

Ok.

>
>> Avoid rendering the featuresets to C uint32_t's in crunch_numbers(), and
>> instead do this in write_results().  Update format_uint32s() to call
>> featureset_to_uint32s() internally.
>>
>> No functional change - the generated cpuid-autogen.h is identical.
> I notice the "special" field (or however such is called in Python)
> goes away, in favor of using raw['!'] at the apparently sole
> consuming site. I also notice the same isn't true for "pv", which
> now could also be raw['A'] as it seems. If this is the case (i.e.
> I'm not overlooking anything), could you say a word on the change
> for "special" and/or the difference between "special" and "pv"?

There is no point copying data just for the sake of copying data.

While we could drop state.pv (pv_def by the end of the series), that is
the only set it would be true for, and dropping it does interfere with
the derivation of raw_shadow (raw_shadow_def by the end of the series).

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel