[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 03/10] x86/gen-cpuid: Rework internal logic to ease future changes

On 26.02.2020 21:22, Andrew Cooper wrote:
> Better split the logic between parse/calculate/write.  Collect the feature
> comment by their comment character, and perform the accumulation operations in
> crunch_numbers().

Would you mind saying "character(s)" here, as there are items with
multiple of them?

> Avoid rendering the featuresets to C uint32_t's in crunch_numbers(), and
> instead do this in write_results().  Update format_uint32s() to call
> featureset_to_uint32s() internally.
> No functional change - the generated cpuid-autogen.h is identical.

I notice the "special" field (or however such is called in Python)
goes away, in favor of using raw['!'] at the apparently sole
consuming site. I also notice the same isn't true for "pv", which
now could also be raw['A'] as it seems. If this is the case (i.e.
I'm not overlooking anything), could you say a word on the change
for "special" and/or the difference between "special" and "pv"?

> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

With my limited Python skills merely
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.