[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [XEN PATCH v3 06/23] xen/build: Fix section-renaming of libfdt and libelf

On 26.02.2020 12:33, Anthony PERARD wrote:
> In common/libelf/Makefile, when SECTIONS gets defined
> SPECIAL_DATA_SECTIONS doesn't exist, so only "text data" sections are
> been renamed. This was different before 48115d14743e ("Move more
> kernel decompression bits to .init.* sections").

Obviously I can't have checked the generated binary back then.

Why is libfdt mentioned in just the title though?

> Move SPECIAL_DATA_SECTIONS in Rules.mk before including "Makefile" to
> fix this.
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
(preferably with a sentence added to the description making clear
how/why that one's also affected; could be as simple as "The same
mistake has then been propagate into libfdt, by way of commit ...",
which ought to be easy enough to add while committing.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.