[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 01/10] x86/sysctl: Don't return cpu policy data for compiled-out support (2)

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 27 Feb 2020 09:33:12 +0000
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@xxxxxxxxxx; spf=Pass smtp.mailfrom=Andrew.Cooper3@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Thu, 27 Feb 2020 09:33:20 +0000
  • Ironport-sdr: FAsS37UnYAxP5Hgn8ggHu8CEk8R9ZbqmpCvSEWTyV/4ytbjXtRCYY2R87XQgfjyVzj9gQG6DsZ CRpZI0Yfrj0ixlF30yTOyYaSUz/l/9Fk8+TSher7ZC+yB8gYJV2mCVPxmZJwUpBQcFPSjtrhlS 7QTuxLD/+n/a2lAFKRh16+KVnulbDqWjdiKKw/3wXNducGTLqBIiLcb1OtDVWFKwJsY0GwIk3K fu6wX4QfBLTqwLoBhstYxJuPfnHMIZdWWT7x4t3f9+7lOehu6n79djhq6zuV2UlK4vM3u4Zohs o0Y=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 27/02/2020 07:38, Jan Beulich wrote:
> On 26.02.2020 21:22, Andrew Cooper wrote:
>> Just as with c/s 96dc77b4b1 for XEN_SYSCTL_get_cpu_policy,
>> XEN_SYSCTL_get_cpu_featureset needs to become conditional.
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> Albeit I'd say "want", not "needs" in the description.

It occurs to me that XEN_SYSCTL_get_cpu_featureset is strictly a subset
of XEN_SYSCTL_get_cpu_policy, and that now I've adjusted the toolstack
onto get_cpu_policy, the sole remaining user is xen-cpuid.

get_cpu_policy already has separate default and max indices, whereas
get_cpu_featureset was written before the need for this has become obvious.

This leads to an asymmetry in xen-cpuid, where the -p (policy) option
provides two more sets of information than the featureset listing.

Instead, I think I'd like to drop XEN_SYSCTL_get_cpu_featureset and
update the sole user to the more complete interface.



Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.