[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/MCFG: fix off-by-one in E820 check



On Fri, Feb 07, 2020 at 02:25:17PM +0100, Jan Beulich wrote:
> Also adjust the comment ahead of e820_all_mapped() to clarify that the
> range is not inclusive at its end.
> 
> Reported-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/xen/arch/x86/e820.c
> +++ b/xen/arch/x86/e820.c
> @@ -38,7 +38,7 @@ struct e820map e820;
>  struct e820map __initdata e820_raw;
>  
>  /*
> - * This function checks if the entire range <start,end> is mapped with type.
> + * This function checks if the entire range [start,end) is mapped with type.
>   *
>   * Note: this function only works correct if the e820 table is sorted and

Wouldn't mind if you took the opportunity to also s/correct/correctly/
in the sentence above.

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.