Re: [Xen-devel] [PATCH] x86/MCFG: fix off-by-one in E820 check

[Jan Beulich <jbeulich@xxxxxxxx>]

On 07.02.2020 15:25, Wei Liu wrote:
> On Fri, Feb 07, 2020 at 02:25:17PM +0100, Jan Beulich wrote:
>> Also adjust the comment ahead of e820_all_mapped() to clarify that the
>> range is not inclusive at its end.
>>
>> Reported-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Reviewed-by: Wei Liu <wl@xxxxxxx>

Thanks.

>> --- a/xen/arch/x86/e820.c
>> +++ b/xen/arch/x86/e820.c
>> @@ -38,7 +38,7 @@ struct e820map e820;
>>  struct e820map __initdata e820_raw;
>>  
>>  /*
>> - * This function checks if the entire range <start,end> is mapped with type.
>> + * This function checks if the entire range [start,end) is mapped with type.
> 
> There is another instance of <> inside e820_all_mapped. It would be good
> if that's fixed too.

That one isn't misleading (talking about just the start of the
region), so I left it alone. But since you've asked for it -
fixed.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel