Re: [Xen-devel] [PATCH v6 06/11] x86/hyperv: provide Hyper-V hypercall functions

[Wei Liu <wl@xxxxxxx>]

On Mon, Feb 03, 2020 at 02:26:24PM +0100, Jan Beulich wrote:
> On 31.01.2020 18:49, Wei Liu wrote:
> > --- a/xen/arch/x86/mm.c
> > +++ b/xen/arch/x86/mm.c
> > @@ -375,9 +375,11 @@ void __init arch_init_memory(void)
> >      }
> >  #endif
> >  
> > -    /* Generate a symbol to be used in linker script */
> > +    /* Generate symbols to be used in linker script */
> >      asm ( ".equ FIXADDR_X_SIZE, %P0; .global FIXADDR_X_SIZE"
> >            :: "i" (FIXADDR_X_SIZE) );
> > +    asm ( ".equ HV_HCALL_PAGE, %P0; .global HV_HCALL_PAGE"
> > +          :: "i" (__fix_x_to_virt(FIX_X_HYPERV_HCALL)) );
> 
> Would this even build without CONFIG_HYPERV_GUEST? In any event
> it doesn't belong here, but should go in a Hyper-V specific
> file.
> 

Good catch. When I did my full build tests it was done with my previous
version.

I can move this to hyperv.c.

> Seeing you now need two of these, how about macro-izing the
> construct?

What name would you suggest? I'm thinking about GEN_XEN_LDS_SYMBOL.

And presumably I should put it in xen/lib.h?

Wei.

> 
> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel