Re: [Xen-devel] [PATCH v6 06/11] x86/hyperv: provide Hyper-V hypercall functions

[Jan Beulich <jbeulich@xxxxxxxx>]

On 31.01.2020 18:49, Wei Liu wrote:
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -375,9 +375,11 @@ void __init arch_init_memory(void)
>      }
>  #endif
>  
> -    /* Generate a symbol to be used in linker script */
> +    /* Generate symbols to be used in linker script */
>      asm ( ".equ FIXADDR_X_SIZE, %P0; .global FIXADDR_X_SIZE"
>            :: "i" (FIXADDR_X_SIZE) );
> +    asm ( ".equ HV_HCALL_PAGE, %P0; .global HV_HCALL_PAGE"
> +          :: "i" (__fix_x_to_virt(FIX_X_HYPERV_HCALL)) );

Would this even build without CONFIG_HYPERV_GUEST? In any event
it doesn't belong here, but should go in a Hyper-V specific
file.

Seeing you now need two of these, how about macro-izing the
construct?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel