[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE





On 23/01/2020 15:46, Durrant, Paul wrote:
-----Original Message-----
From: Julien Grall <julien@xxxxxxx>
Sent: 23 January 2020 15:26
To: Durrant, Paul <pdurrant@xxxxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
Cc: Jan Beulich <jbeulich@xxxxxxxx>; Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Roger Pau Monné
<roger.pau@xxxxxxxxxx>; George Dunlap <George.Dunlap@xxxxxxxxxxxxx>; Ian
Jackson <ian.jackson@xxxxxxxxxxxxx>; Konrad Rzeszutek Wilk
<konrad.wilk@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Jun
Nakajima <jun.nakajima@xxxxxxxxx>; Kevin Tian <kevin.tian@xxxxxxxxx>
Subject: Re: [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for
APIC_DEFAULT_PHYS_BASE



On 23/01/2020 14:03, Paul Durrant wrote:
diff --git a/xen/common/domain.c b/xen/common/domain.c
index ee3f9ffd3e..30c777acb8 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -339,6 +339,8 @@ static int sanitise_domain_config(struct
xen_domctl_createdomain *config)
       return arch_sanitise_domain_config(config);
   }

+#define DOMAIN_INIT_PAGES 1

Would it make sense to make this a per-arch define? This would allow
each arch to define a different number of init pages (and catch any
misuse).


I thought about that and decided against it. The arch code may want to increase 
(which may be a bad idea) but I think it should be set early. Ultimately it 
should come in from the toolstack via the domctl anyway.
The value is already arch specific because on Arm we have 0 pages requires this trick yet.

While I agree, it should be set early, there is nothing to prevent this to be in a arch header. Am I correct?

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.