Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

[Julien Grall <julien@xxxxxxx>]

On 23/01/2020 14:03, Paul Durrant wrote:
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index ee3f9ffd3e..30c777acb8 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -339,6 +339,8 @@ static int sanitise_domain_config(struct 
> xen_domctl_createdomain *config)
>       return arch_sanitise_domain_config(config);
>   }
>   
> +#define DOMAIN_INIT_PAGES 1
Would it make sense to make this a per-arch define? This would allow 
each arch to define a different number of init pages (and catch any misuse).
> +
>   struct domain *domain_create(domid_t domid,
>                                struct xen_domctl_createdomain *config,
>                                bool is_priv)
> @@ -441,6 +443,12 @@ struct domain *domain_create(domid_t domid,
>           radix_tree_init(&d->pirq_tree);
>       }
>   
> +    /*
> +     * Allow a limited number of special pages to be allocated for the
> +     * domain
> +     */
> +    d->max_pages = DOMAIN_INIT_PAGES;
> +
>       if ( (err = arch_domain_create(d, config)) != 0 )
>           goto fail;
>       init_status |= INIT_arch;
> diff --git a/xen/include/asm-x86/mm.h b/xen/include/asm-x86/mm.h
> index 2ca8882ad0..e429f38228 100644
> --- a/xen/include/asm-x86/mm.h
> +++ b/xen/include/asm-x86/mm.h
> @@ -317,8 +317,6 @@ struct page_info
>   
>   #define maddr_get_owner(ma)   (page_get_owner(maddr_to_page((ma))))
>   
> -extern void free_shared_domheap_page(struct page_info *page);
> -
>   #define frame_table ((struct page_info *)FRAMETABLE_VIRT_START)
>   extern unsigned long max_page;
>   extern unsigned long total_pages;
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel