Re: [Xen-devel] [PATCH 2/6] x86/suspend: Don't bother saving %cr3, %ss or flags

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Dec 17, 2019 at 12:06:01PM +0000, Andrew Cooper wrote:
> On 17/12/2019 11:52, Roger Pau Monné wrote:
> > On Fri, Dec 13, 2019 at 07:04:32PM +0000, Andrew Cooper wrote:
> >> The trampoline has already set up the idle pagetables (which are the 
> >> correct
> >> ones to use), and sanitised the flags state.
> > I wonder why do we have wakeup.S and wakeup_prot.S, it would be easier
> > to follow if it all was in the same file IMO.
> 
> wakeup.S is the 16bit entry point, and lives in the trampoline below 1M.
> 
> wakeup_prot.S is a bit of logic which lives in the main hypervisor.
> 
> The naming could probably do with some improvement, but they can't
> feasibly be part of the same file.

Hm, I'm not sure I follow. Isn't this trampoline copied by Xen in a
suitable position below the 1M boundary, and hence could use symbols
in order to figure out which part to copy?

Ie: both the low and the high part could live in the same file as long
as Xen knows how to differentiate those and which chunk needs
positioning below 1M?

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel