[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/6] x86/suspend: Don't bother saving %cr3, %ss or flags


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 17 Dec 2019 12:52:41 +0100
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@xxxxxxxxxx; spf=Pass smtp.mailfrom=roger.pau@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
  • Delivery-date: Tue, 17 Dec 2019 11:52:55 +0000
  • Ironport-sdr: 3/7ZCfId545CsRP0LXlgH2PvILUoJ1qtWcm9wtc//3W2IEXz+t608tAIU2ByhomJm68nWmHJcC CKI1WHl4vfd4cLXo7EL2vq+OUh2vHhsxBiHeLJ5GUg9mMDM5sgVMx4MflIXorCGBeNbG43eExV tDMJKwVweSJOJdF3PBsD23SzCP4z8ezUStOY9Y2ZygZKVcpX7DpgU1sNdoobrAfYHgWRlUxuAY iY9xVgldy6CuSH0UucgguG03Dq148LnZKK5vMD5htpMrMt78i1246BA3SM8qDuclvZO4Vlx0lK jK8=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Dec 13, 2019 at 07:04:32PM +0000, Andrew Cooper wrote:
> The trampoline has already set up the idle pagetables (which are the correct
> ones to use), and sanitised the flags state.

I wonder why do we have wakeup.S and wakeup_prot.S, it would be easier
to follow if it all was in the same file IMO.

> 
> For %ss, __HYPERVISOR_DS64 is the correct descriptor to restore.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.