Re: [Xen-devel] [PATCH v2] Xen missing prompt log when exec-sp=off

[Jan Beulich <jbeulich@xxxxxxxx>]

On 16.12.2019 12:51, Jin Nan Wang wrote:
> 
> On 16/12/2019 7:00 pm, Jan Beulich wrote:
>> On 16.12.2019 09:27, Jin Nan Wang wrote:
>>> Fix a issue when user disable ETP exec-sp, xen missed a prompt
>>> log in dmesg.
>> Why "missed" (and why "prompt")? I think the original intention
>> was to log a message only when no command line option was given
>> and the system would be vulnerable without the disabling.
> 
> Yes, I guess it.
> 
> But when I test ept=exec-sp=off. I got a little confused.
> 
> Because of the "prompt" tell me it's disabled, at default.
> 
> when I add 'ept=exec-sp=off', the "prompt" is disappeared. It seems like 
> it's ENABLED.

But when you don't see the log message (which btw is not a prompt)
the next step then would be to check the command line. When you
see "off" there, you'll know it's off. No confusion at all.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel