[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] Xen missing prompt log when exec-sp=off


  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Jin Nan Wang <jnwang@xxxxxxxx>
  • Date: Mon, 16 Dec 2019 11:51:03 +0000
  • Accept-language: zh-CN, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SyLbeEYfDFfRgjyJa2qtEEdENlBDRkrqDFeonlJJS8A=; b=QLBqwMbE3V211bxxBbcBFNbQcQCv3uijE7DJ0gPi+HmxjsYOAcmpPUftslo7/UsQmRK3N75BG1sDjCH5DM1TW2z4raJqmgIR53d7ecdXDfBcqc2t5HIDqhc5tbjwtYgSs+anoLJ8JDOS38dmXoUuUXc1BXXyklQUrMVX9jPd7VrjNtP9TmEOHbhvOwP4j+zcYYwnOn4ToB+Pkgwp4PLb5qq665kj/pBJVtwO7K+9vldZleIt3aC4aRiDyn4jN8rhAgNvikzXkXQOJq2CgGtKWStXiUb/Gsu2mu2MvHcAdSzaX0lIDYYpXjb9Z25fnkm7SQb3LR9rZYkW0exIv7mkTw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XWSoB90sgIBmAx5rlcun7RkDlRHC/8efFbZo4wDzqLA43gQZBGZYuqhZm9fHBuofJjXL5LuqtZHXE2yDs2DnmntqghBlU/G1ub584ii5BViKDHR0B+tUkTC3DR4XElUt5QpUMVJC+R/9qEsP5/UMZWeZNuDDWKwXuBK2E1a9E65MGYF0FWFt3hu4rJvYATyD3nyBoAiSXAQxcw8ZqJaZbMu5kZQLJvYg7U3zfp+4EpLinZDo1K4m12/6FSmBTzNIEBWW6tpXTdb/weQMFY16hGZnoYeyEcP+HcCb8Fz0W8S8apoPU7dF/QJMDrwFrEm2AXaedp2zTDAZ5ig/SLwFgg==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=jnwang@xxxxxxxx;
  • Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 16 Dec 2019 12:05:49 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVs+qzuwFrdBKM3kC0biftq9U4/qe8mEoAgAAOAAA=
  • Thread-topic: [PATCH v2] Xen missing prompt log when exec-sp=off

On 16/12/2019 7:00 pm, Jan Beulich wrote:
> On 16.12.2019 09:27, Jin Nan Wang wrote:
>> Fix a issue when user disable ETP exec-sp, xen missed a prompt
>> log in dmesg.
> Why "missed" (and why "prompt")? I think the original intention
> was to log a message only when no command line option was given
> and the system would be vulnerable without the disabling.

Yes, I guess it.

But when I test ept=exec-sp=off. I got a little confused.

Because of the "prompt" tell me it's disabled, at default.

when I add 'ept=exec-sp=off', the "prompt" is disappeared. It seems like 
it's ENABLED.


James

> Nevertheless two style remarks as well:
>
>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> @@ -2495,14 +2495,14 @@ const struct hvm_function_table * __init 
>> start_vmx(void)
>>       {
>>           bool cpu_has_bug_pschange_mc = has_if_pschange_mc();
>>   
>> +        /* Default to non-executable superpages on vulnerable hardware. */
>>           if ( opt_ept_exec_sp == -1 )
>> -        {
>> -            /* Default to non-executable superpages on vulnerable hardware. 
>> */
>>               opt_ept_exec_sp = !cpu_has_bug_pschange_mc;
>>   
>> -            if ( cpu_has_bug_pschange_mc )
>> -                printk("VMX: Disabling executable EPT superpages due to 
>> CVE-2018-12207\n");
>> -        }
>> +        if (opt_ept_exec_sp)
> Missing blanks inside ().
>
>> +            printk("VMX: Enable executable EPT superpages.\n");
> No full stop here please.
>
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.