Re: [Xen-devel] [XEN PATCH 6/8] xen: Move CONFIG_INDIRECT_THUNK to Kconfig

[Jan Beulich <jbeulich@xxxxxxxx>]

On 12.12.2019 19:27, Anthony PERARD wrote:
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -32,6 +32,9 @@ config ARCH_DEFCONFIG
>       string
>       default "arch/x86/configs/x86_64_defconfig"
>  
> +config INDIRECT_THUNK
> +     def_bool $(cc-option,-mindirect-branch-register)

I'm not happy to see constructs like this appear. They leave a
"# CONFIG_... is not defined" in .config for no reason when
the expression evaluates to n. This may not matter much when
considering just one such line, but it will when we gain
dozens or hundreds. For options without prompts I think the
default should only ever be set to y (or m, which we don't
use). The above would then be written as

config INDIRECT_THUNK
        def_bool y if $(cc-option,-mindirect-branch-register)

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel