Re: [Xen-devel] [XEN PATCH 3/8] xen: Update Kconfig to Linux v5.4

[Jan Beulich <jbeulich@xxxxxxxx>]

Just two minor remarks:

On 12.12.2019 19:27, Anthony PERARD wrote:
> --- /dev/null
> +++ b/docs/misc/kconfig-macro-language.rst
> @@ -0,0 +1,247 @@
> +======================
> +Kconfig macro language
> +======================
> +
> +Concept
> +-------
> +
> +The basic idea was inspired by Make. When we look at Make, we notice sort of
> +two languages in one. One language describes dependency graphs consisting of
> +targets and prerequisites. The other is a macro language for performing 
> textual
> +substitution.
> +
> +There is clear distinction between the two language stages. For example, you
> +can write a makefile like follows::
> +
> +    APP := foo
> +    SRC := foo.c
> +    CC := gcc
> +
> +    $(APP): $(SRC)
> +            $(CC) -o $(APP) $(SRC)
> +
> +The macro language replaces the variable references with their expanded form,
> +and handles as if the source file were input like follows::
> +
> +    foo: foo.c
> +            gcc -o foo foo.c
> +
> +Then, Make analyzes the dependency graph and determines the targets to be
> +updated.
> +
> +The idea is quite similar in Kconfig - it is possible to describe a Kconfig
> +file like this::
> +
> +    CC := gcc
> +
> +    config CC_HAS_FOO
> +            def_bool $(shell, $(srctree)/scripts/gcc-check-foo.sh $(CC))
> +
> +The macro language in Kconfig processes the source file into the following
> +intermediate::
> +
> +    config CC_HAS_FOO
> +            def_bool y
> +
> +Then, Kconfig moves onto the evaluation stage to resolve inter-symbol
> +dependency as explained in kconfig-language.txt.

.rst ?


> --- /dev/null
> +++ b/xen/.gitignore
> @@ -0,0 +1,2 @@
> +*.lex.c
> +*.tab.[ch]

Why do these get moved here from ...

> --- a/xen/tools/kconfig/.gitignore
> +++ b/xen/tools/kconfig/.gitignore
> @@ -1,12 +1,8 @@
>  #
>  # Generated files
>  #
> -config*
> -*.lex.c
> -*.tab.c
> -*.tab.h
> -zconf.hash.c
>  *.moc
> +*conf-cfg

here?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel