Re: [Xen-devel] [PATCH for-next 1/7] x86: import hyperv-tlfs.h from Linux

[Jan Beulich <jbeulich@xxxxxxxx>]

On 10.12.2019 16:37, Durrant, Paul wrote:
>> -----Original Message-----
>> From: Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of Jan
>> Beulich
>> Sent: 10 December 2019 15:34
>> To: Wei Liu <wl@xxxxxxx>
>> Cc: Wei Liu <liuwe@xxxxxxxxxxxxx>; Paul Durrant <paul@xxxxxxx>; Andrew
>> Cooper <andrew.cooper3@xxxxxxxxxx>; Michael Kelley
>> <mikelley@xxxxxxxxxxxxx>; Xen Development List <xen-
>> devel@xxxxxxxxxxxxxxxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> Subject: Re: [Xen-devel] [PATCH for-next 1/7] x86: import hyperv-tlfs.h
>> from Linux
>>
>> On 25.10.2019 11:16, Wei Liu wrote:
>>> Taken from Linux commit b2d8b167e15bb5ec2691d1119c025630a247f649.
>>>
>>> This is a pristine copy from Linux. It is not used yet and probably
>>> doesn't compile. Changes to make it work will come later.
>>>
>>> Signed-off-by: Wei Liu <liuwe@xxxxxxxxxxxxx>
>>
>> This coming from Linux and assuming at least a fair part of it is
>> going to be used, in principle
>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> However, there are many seemingly unnecessary uses of __packed
>> here, which I'd rather not see go in at all (i.e. not be dropped
>> later on, and then potentially missing some). I find ...
>>
>>> +typedef struct _HV_REFERENCE_TSC_PAGE {
>>> +   __u32 tsc_sequence;
>>> +   __u32 res1;
>>> +   __u64 tsc_scale;
>>> +   __s64 tsc_offset;
>>> +}  __packed HV_REFERENCE_TSC_PAGE, *PHV_REFERENCE_TSC_PAGE;
>>
> 
> You realise there's a definition of this in the viridian code already, right?

It looked familiar, but it didn't occur to me to point this out.
Yes, there looks to be room for deduplication...

Actually, Wei, one more thing I was curious about - what is "tlfs"
an acronym of?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel