Re: [Xen-devel] [PATCH for-next 1/7] x86: import hyperv-tlfs.h from Linux

[Jan Beulich <jbeulich@xxxxxxxx>]

On 25.10.2019 11:16, Wei Liu wrote:
> Taken from Linux commit b2d8b167e15bb5ec2691d1119c025630a247f649.
> 
> This is a pristine copy from Linux. It is not used yet and probably
> doesn't compile. Changes to make it work will come later.
> 
> Signed-off-by: Wei Liu <liuwe@xxxxxxxxxxxxx>

This coming from Linux and assuming at least a fair part of it is
going to be used, in principle
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

However, there are many seemingly unnecessary uses of __packed
here, which I'd rather not see go in at all (i.e. not be dropped
later on, and then potentially missing some). I find ...

> +typedef struct _HV_REFERENCE_TSC_PAGE {
> +     __u32 tsc_sequence;
> +     __u32 res1;
> +     __u64 tsc_scale;
> +     __s64 tsc_offset;
> +}  __packed HV_REFERENCE_TSC_PAGE, *PHV_REFERENCE_TSC_PAGE;

.. this one particularly suspicious: I don't think it is well
defined for __packed to also apply to the type
PHV_REFERENCE_TSC_PAGE points to (and I suspect it doesn't).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel