Re: [Xen-devel] [PATCH v2] passthrough: drop break statement following c/s cd7dedad820

["Durrant, Paul" <pdurrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
> Sent: 05 December 2019 12:14
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: jbeulich@xxxxxxxx; linux@xxxxxxxxxxxxxx; Durrant, Paul
> <pdurrant@xxxxxxxxxx>; Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
> Subject: [PATCH v2] passthrough: drop break statement following c/s
> cd7dedad820
> 
> The locking responsibilities have changed and a premature break in
> this section now causes the following assertion:
> 
> Assertion '!preempt_count()' failed at preempt.c:36
> 
> Suggested-by: Paul Durrant <pdurrant@xxxxxxxxxx>

Actually, it was suggested by Jan, but you can put my R-b on the patch.

  Paul

> Reported-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
> Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
> ---
>  xen/drivers/passthrough/pci.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index ced0c28..c07a639 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -1705,7 +1705,6 @@ int iommu_do_pci_domctl(
>                         seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn));
>                  ret = -EINVAL;
>              }
> -            break;
>          }
>          else if ( !ret )
>              ret = assign_device(d, seg, bus, devfn, flags);
> --
> 2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel