Re: [Xen-devel] [PATCH v3] xen/x86: vpmu: Unmap per-vCPU PMU page when the domain is destroyed

[Boris Ostrovsky <BORIS.OSTROVSKY@xxxxxxxxxx>]

> On Dec 4, 2019, at 10:55 AM, Julien Grall <jgrall@xxxxxxxxxx> wrote:
> 
> Hi Boris,
> 
> On 28/11/2019 21:50, Boris Ostrovsky wrote:
>> On 11/28/19 5:23 AM, Jan Beulich wrote:
>>> On 28.11.2019 10:38, Paul Durrant wrote:
>>> 
>>>> --- a/xen/arch/x86/cpu/vpmu.c
>>>> +++ b/xen/arch/x86/cpu/vpmu.c
>>>> @@ -576,11 +576,36 @@ static void vpmu_arch_destroy(struct vcpu *v)
>>>>             vpmu->arch_vpmu_ops->arch_vpmu_destroy(v);
>>>>      }
>>>> +
>>>> +    vpmu_reset(vpmu, VPMU_CONTEXT_ALLOCATED);
>>>>  }
>>> Boris, to be on the safe side - are you in agreement with this
>>> change, now that the setting of the flag is being left untouched?
>> Yes, this is fine.
> 
> Can we take this as an ACK?


Yes, of course.


-boris


> 
>> (I probably would clear it in arch_vpmu_destroy op since it is set in
>> arch-specific code but either way works)
>> -boris
> 
> Cheers,


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel