[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3] xen/x86: vpmu: Unmap per-vCPU PMU page when the domain is destroyed

Hi Boris,

On 28/11/2019 21:50, Boris Ostrovsky wrote:
On 11/28/19 5:23 AM, Jan Beulich wrote:
On 28.11.2019 10:38, Paul Durrant wrote:

--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -576,11 +576,36 @@ static void vpmu_arch_destroy(struct vcpu *v)
+    vpmu_reset(vpmu, VPMU_CONTEXT_ALLOCATED);
Boris, to be on the safe side - are you in agreement with this
change, now that the setting of the flag is being left untouched?

Yes, this is fine.

Can we take this as an ACK?

(I probably would clear it in arch_vpmu_destroy op since it is set in
arch-specific code but either way works)



Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.