Re: [Xen-devel] [PATCH] tools/hotpug: only attempt to call 'ip route' if there is valid command

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, Oct 24, 2019 at 03:21:03PM +0100, paul@xxxxxxx wrote:
> From: Paul Durrant <pdurrant@xxxxxxxxxx>
> 
> The vif-route script should only call 'ip route' when 'ipcmd' has been
> set, otherwise it will fail due to an incorrect command string.
> 
> Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> This appears to have been broken forever.

Or probably since c0efb8dc852805fd4d3c2691aca1f6c52f6b6ac7, 13 years
ago.

> ---
>  tools/hotplug/Linux/vif-route | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/hotplug/Linux/vif-route b/tools/hotplug/Linux/vif-route
> index c149ffca73..98893d90b6 100644
> --- a/tools/hotplug/Linux/vif-route
> +++ b/tools/hotplug/Linux/vif-route
> @@ -35,7 +35,7 @@ case "${command}" in
>          ;;
>  esac
>  
> -if [ "${ip}" ] ; then
> +if [ "${ipcmd}" ] ; then

The commit message and this new condition doesn't really explain what is
happening.
Does that means we only need to run `ip route` when command is 'online'
or 'offline'? Is there something else to do 'add' and 'remove'?

Could you add something in the commit message, and maybe a comment?

Thanks,


-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel