Re: [Xen-devel] [PATCH v3 2/4] x2APIC: simplify resume

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Oct 17, 2019 at 10:26:08AM +0200, Marek Marczykowski-Górecki wrote:
> On Tue, Oct 15, 2019 at 05:47:34PM +0200, Roger Pau Monne wrote:
> > There's no need to save and restore the IO-APIC entries, the entries
> > prior to suspension have already been saved by ioapic_suspend, and
> > will be restored by ioapic_resume. Note that at the point where
> > resume_x2apic gets called the IO-APIC has not yet resumed, and hence
> > all entries should be masked.
> > 
> > Note this shouldn't introduce any functional change.
> > 
> > Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> I've tried host suspend without any domU running and it works. I've tested
> just this patch without others in the series, does it matter?

No that's fine.

> Tested-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>

Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel