[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v4 1/4] xen: fix debugtrace clearing
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Juergen Gross <jgross@xxxxxxxx>
- Date: Wed, 4 Sep 2019 16:25:02 +0200
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 04 Sep 2019 14:25:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.09.19 15:53, Jan Beulich wrote:
On 04.09.2019 15:46, Juergen Gross wrote:
@@ -1281,14 +1280,14 @@ void debugtrace_printk(const char *fmt, ...)
{
if ( strcmp(buf, last_buf) )
{
- last_prd = debugtrace_prd;
+ debugtrace_prd_last = debugtrace_prd;
last_count = ++count;
safe_strcpy(last_buf, buf);
snprintf(cntbuf, sizeof(cntbuf), "%u ", count);
}
else
{
- debugtrace_prd = last_prd;
+ debugtrace_prd = debugtrace_prd_last;
snprintf(cntbuf, sizeof(cntbuf), "%u-%u ", last_count, ++count);
}
debugtrace_add_to_buf(cntbuf);
I'm afraid it is rather last_buf[] which needs invalidating, at
which point last_prd could imo remain local to this function.
Hmm, right. Will change.
I'll send a new series as soon as you indicate you won't have further
comments to any patch of the series.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
