Re: [Xen-devel] [PATCH v4 1/4] xen: fix debugtrace clearing

[Jan Beulich <jbeulich@xxxxxxxx>]

On 04.09.2019 15:46, Juergen Gross wrote:
> @@ -1281,14 +1280,14 @@ void debugtrace_printk(const char *fmt, ...)
>      {
>          if ( strcmp(buf, last_buf) )
>          {
> -            last_prd = debugtrace_prd;
> +            debugtrace_prd_last = debugtrace_prd;
>              last_count = ++count;
>              safe_strcpy(last_buf, buf);
>              snprintf(cntbuf, sizeof(cntbuf), "%u ", count);
>          }
>          else
>          {
> -            debugtrace_prd = last_prd;
> +            debugtrace_prd = debugtrace_prd_last;
>              snprintf(cntbuf, sizeof(cntbuf), "%u-%u ", last_count, ++count);
>          }
>          debugtrace_add_to_buf(cntbuf);

I'm afraid it is rather last_buf[] which needs invalidating, at
which point last_prd could imo remain local to this function.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel