Re: [Xen-devel] [PATCH] x86/boot: Annotate pagetables with STT_OBJECT

[Jan Beulich <jbeulich@xxxxxxxx>]

On 14.08.2019 14:00, Wei Liu wrote:
> On Wed, Aug 14, 2019 at 11:44:04AM +0100, Andrew Cooper wrote:
> [...]
> > diff --git a/xen/include/asm-x86/config.h b/xen/include/asm-x86/config.h
> > index 22dc795eea..35705441ff 100644
> > --- a/xen/include/asm-x86/config.h
> > +++ b/xen/include/asm-x86/config.h
> > @@ -56,6 +56,11 @@
> >   #define GLOBAL(name)                            \
> >     .globl name;                                  \
> >     name:
> > +
> > +#define ENDDATA(name)                           \
> > +    .type name, STT_OBJECT;                     \
> Isn't the correct syntax
>
>      .type name STT_OBJECT;
>
> ?
>
> The comma shouldn't be there according to as manual.
Quote 1:

"ELF Version
 -----------

 For ELF targets, the '.type' directive is used like this:

     .type NAME , TYPE DESCRIPTION
"

The comma is definitely here, unconditionally. But yes, quote 2:

'   The syntaxes supported are:

        .type <name> STT_<TYPE_IN_UPPER_CASE>
        .type <name>,#<type>
        .type <name>,@<type>
        .type <name>,%<type>
        .type <name>,"<type>"'

Judging from the sources all forms treat the comma as optional.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel