Re: [Xen-devel] [PATCH v2] print: introduce a format specifier for pci_sbdf_t

[Jan Beulich <jbeulich@xxxxxxxx>]

On 22.08.2019 08:51, Roger Pau Monne wrote:
> The new format specifier is '%pp', and prints a pci_sbdf_t using the
> seg:bus:dev.func format. Replace all SBDFs printed using
> '%04x:%02x:%02x.%u' to use the new format specifier.
>
> No functional change intended.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Changes since v1:
>   - Use base 8 to print the function number.
>   - Sort the addition in the pointer function alphabetically.
> ---
>   docs/misc/printk-formats.txt                |   5 +
>   xen/arch/x86/hvm/vmsi.c                     |  10 +-
>   xen/arch/x86/msi.c                          |  35 +++---
>   xen/common/vsprintf.c                       |  18 ++++
>   xen/drivers/passthrough/amd/iommu_acpi.c    |  17 ++-
>   xen/drivers/passthrough/amd/iommu_cmd.c     |   5 +-
>   xen/drivers/passthrough/amd/iommu_detect.c  |   5 +-
>   xen/drivers/passthrough/amd/iommu_init.c    |  12 +--
>   xen/drivers/passthrough/amd/iommu_intr.c    |   3 +-
>   xen/drivers/passthrough/amd/pci_amd_iommu.c |  25 ++---
>   xen/drivers/passthrough/pci.c               | 114 ++++++++------------
>   xen/drivers/passthrough/vtd/dmar.c          |  25 +++--
>   xen/drivers/passthrough/vtd/intremap.c      |  11 +-
>   xen/drivers/passthrough/vtd/iommu.c         |  80 ++++++--------
>   xen/drivers/passthrough/vtd/quirks.c        |  22 ++--
>   xen/drivers/passthrough/vtd/utils.c         |   6 +-
>   xen/drivers/passthrough/x86/ats.c           |  13 +--
>   xen/drivers/vpci/header.c                   |  11 +-
>   xen/drivers/vpci/msi.c                      |   6 +-
>   xen/drivers/vpci/msix.c                     |  24 ++---
>   20 files changed, 189 insertions(+), 258 deletions(-)
In order to not block forward progress, for just the pieces where I am
the only maintainer
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
By implication I still don't really agree with using a %p extension
here.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel