[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] print: introduce a format specifier for pci_sbdf_t

On Thu, Aug 22, 2019 at 08:51:32AM +0200, Roger Pau Monne wrote:
> The new format specifier is '%pp', and prints a pci_sbdf_t using the
> seg:bus:dev.func format. Replace all SBDFs printed using
> '%04x:%02x:%02x.%u' to use the new format specifier.
> No functional change intended.
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

This patch is missing the chunk below, I would appreciate if it can be
merged while commiting if the patch gets the relevant Acks/RBs, or
else I can resend with the chunk added.

Thanks, Roger.
diff --git a/xen/drivers/passthrough/amd/iommu_intr.c 
index 687a7fa922..1c907cff52 100644
--- a/xen/drivers/passthrough/amd/iommu_intr.c
+++ b/xen/drivers/passthrough/amd/iommu_intr.c
@@ -898,10 +898,8 @@ static void dump_intremap_table(const struct amd_iommu 
         if ( ivrs_mapping )
-            printk("  %04x:%02x:%02x:%u:\n", iommu->seg,
-                   PCI_BUS(ivrs_mapping->dte_requestor_id),
-                   PCI_SLOT(ivrs_mapping->dte_requestor_id),
-                   PCI_FUNC(ivrs_mapping->dte_requestor_id));
+            printk("  %pp:\n",
+                   &PCI_SBDF2(iommu->seg, ivrs_mapping->dte_requestor_id));
             ivrs_mapping = NULL;

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.