[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [Qemu-devel] [PATCH v7 25/42] hw/misc: Declare device little or big endian
- To: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, tony.nguyen@xxxxxx, qemu-devel@xxxxxxxxxx
- From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
- Date: Mon, 19 Aug 2019 20:26:36 +0200
- Cc: fam@xxxxxxxxxx, peter.maydell@xxxxxxxxxx, walling@xxxxxxxxxxxxx, dmitry.fleytman@xxxxxxxxx, sagark@xxxxxxxxxxxxxxxxx, mst@xxxxxxxxxx, green@xxxxxxxxxxxxxx, palmer@xxxxxxxxxx, mark.cave-ayland@xxxxxxxxxxxx, balaton@xxxxxxxxxx, keith.busch@xxxxxxxxx, jcmvbkbc@xxxxxxxxx, frederic.konrad@xxxxxxxxxxx, kraxel@xxxxxxxxxx, claudio.fontana@xxxxxxxx, edgar.iglesias@xxxxxxxxx, mreitz@xxxxxxxxxx, pburton@xxxxxxxxxxxx, marex@xxxxxxx, robh@xxxxxxxxxx, hare@xxxxxxxx, gxt@xxxxxxxxxxxxxxx, berto@xxxxxxxxxx, proljc@xxxxxxxxx, qemu-block@xxxxxxxxxx, arikalo@xxxxxxxxxxxx, jslaby@xxxxxxx, deller@xxxxxx, david@xxxxxxxxxx, magnus.damm@xxxxxxxxx, yuval.shaia@xxxxxxxxxx, pasic@xxxxxxxxxxxxx, borntraeger@xxxxxxxxxx, hpoussin@xxxxxxxxxxx, joel@xxxxxxxxx, marcel.apfelbaum@xxxxxxxxx, anthony.perard@xxxxxxxxxx, marcandre.lureau@xxxxxxxxxx, david@xxxxxxxxxxxxxxxxxxxxx, balrogg@xxxxxxxxx, jasowang@xxxxxxxxxx, atar4qemu@xxxxxxxxx, antonynpavlov@xxxxxxxxx, jiri@xxxxxxxxxxx, ehabkost@xxxxxxxxxx, minyard@xxxxxxx, jcd@xxxxxxxxxxxxxxx, sw@xxxxxxxxxxx, alistair@xxxxxxxxxxxxx, chouteau@xxxxxxxxxxx, b.galvani@xxxxxxxxx, eric.auger@xxxxxxxxxx, alex.williamson@xxxxxxxxxx, sstabellini@xxxxxxxxxx, jan.kiszka@xxxxxx, clg@xxxxxxxx, stefanha@xxxxxxxxxx, imammedo@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, shorne@xxxxxxxxx, andrew.smirnov@xxxxxxxxx, jsnow@xxxxxxxxxx, rth@xxxxxxxxxxx, kwolf@xxxxxxxxxx, qemu-s390x@xxxxxxxxxx, qemu-arm@xxxxxxxxxx, xiaoguangrong.eric@xxxxxxxxx, qemu-riscv@xxxxxxxxxx, andrew@xxxxxxxx, lersek@xxxxxxxxxx, crwulff@xxxxxxxxx, laurent@xxxxxxxxx, Andrew.Baumann@xxxxxxxxxxxxx, sundeep.lkml@xxxxxxxxx, i.mitsyanko@xxxxxxxxx, michael@xxxxxxxx, paul.durrant@xxxxxxxxxx, qemu-ppc@xxxxxxxxxx, huth@xxxxxxxxxxxxx, amarkovic@xxxxxxxxxxxx, kbastian@xxxxxxxxxxxxxxxxxxxxx, cohuck@xxxxxxxxxx, peter.chubb@xxxxxxxxxxxx, aurelien@xxxxxxxxxxx, stefanb@xxxxxxxxxxxxx
- Delivery-date: Mon, 19 Aug 2019 18:26:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Openpgp: preference=signencrypt
On 16/08/19 12:04, Philippe Mathieu-Daudé wrote:
>> diff --git a/hw/misc/a9scu.c b/hw/misc/a9scu.c
>> index 4307f00..3de8cd3 100644
>> --- a/hw/misc/a9scu.c
>> +++ b/hw/misc/a9scu.c
>> @@ -94,7 +94,7 @@ static void a9_scu_write(void *opaque, hwaddr offset,
>> static const MemoryRegionOps a9_scu_ops = {
>> .read = a9_scu_read,
>> .write = a9_scu_write,
>> - .endianness = DEVICE_NATIVE_ENDIAN,
>> + .endianness = DEVICE_LITTLE_ENDIAN,
> Uh, I doubt that.
>
... why? :)
Remember that BE32 and BE8 ARM OSes still are "natively" little-endian.
Paolo
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
