[Xen-devel] [Qemu-devel] [PATCH v7 26/42] hw/net: Declare device little or big endian

[<tony.nguyen@xxxxxx>]

For each device declared with DEVICE_NATIVE_ENDIAN, find the set of

targets from the set of target/hw/*/device.o.

If the set of targets are all little or all big endian, re-declare

the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN

respectively.

This *naive* deduction may result in genuinely native endian devices

being incorrectly declared as little or big endian, but should not

introduce regressions for current targets.

These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it

has a new target with an opposite endian or 2) someone informed knows

better =)

Signed-off-by: Tony Nguyen <tony.nguyen@xxxxxx>

---

 hw/net/allwinner_emac.c | 2 +-

 hw/net/imx_fec.c        | 2 +-

 hw/net/lan9118.c        | 4 ++--

 hw/net/lance.c          | 2 +-

 hw/net/smc91c111.c      | 2 +-

 hw/net/stellaris_enet.c | 2 +-

 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/hw/net/allwinner_emac.c b/hw/net/allwinner_emac.c

index eecda52..97e22e7 100644

--- a/hw/net/allwinner_emac.c

+++ b/hw/net/allwinner_emac.c

@@ -418,7 +418,7 @@ static void aw_emac_set_link(NetClientState *nc)

 static const MemoryRegionOps aw_emac_mem_ops = {

     .read = aw_emac_read,

     .write = aw_emac_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

     .valid = {

         .min_access_size = 4,

         .max_access_size = 4,

diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c

index 404154e..76d42c8 100644

--- a/hw/net/imx_fec.c

+++ b/hw/net/imx_fec.c

@@ -1278,7 +1278,7 @@ static const MemoryRegionOps imx_eth_ops = {

     .write                 = imx_eth_write,

     .valid.min_access_size = 4,

     .valid.max_access_size = 4,

-    .endianness            = DEVICE_NATIVE_ENDIAN,

+    .endianness            = DEVICE_LITTLE_ENDIAN,

 };

 

 static void imx_eth_cleanup(NetClientState *nc)

diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c

index f6120be..bb1bbb3 100644

--- a/hw/net/lan9118.c

+++ b/hw/net/lan9118.c

@@ -1304,13 +1304,13 @@ static uint64_t lan9118_16bit_mode_read(void *opaque, hwaddr offset,

 static const MemoryRegionOps lan9118_mem_ops = {

     .read = lan9118_readl,

     .write = lan9118_writel,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static const MemoryRegionOps lan9118_16bit_mem_ops = {

     .read = lan9118_16bit_mode_read,

     .write = lan9118_16bit_mode_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static NetClientInfo net_lan9118_info = {

diff --git a/hw/net/lance.c b/hw/net/lance.c

index 2978c01..d95f170 100644

--- a/hw/net/lance.c

+++ b/hw/net/lance.c

@@ -74,7 +74,7 @@ static uint64_t lance_mem_read(void *opaque, hwaddr addr,

 static const MemoryRegionOps lance_mem_ops = {

     .read = lance_mem_read,

     .write = lance_mem_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_BIG_ENDIAN,

     .valid = {

         .min_access_size = 2,

         .max_access_size = 2,

diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c

index 4a612ee..49e4bf5 100644

--- a/hw/net/smc91c111.c

+++ b/hw/net/smc91c111.c

@@ -757,7 +757,7 @@ static const MemoryRegionOps smc91c111_mem_ops = {

     .write = smc91c111_writefn,

     .valid.min_access_size = 1,

     .valid.max_access_size = 4,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static NetClientInfo net_smc91c111_info = {

diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c

index 2f645bf..15ec227 100644

--- a/hw/net/stellaris_enet.c

+++ b/hw/net/stellaris_enet.c

@@ -456,7 +456,7 @@ static void stellaris_enet_write(void *opaque, hwaddr offset,

 static const MemoryRegionOps stellaris_enet_ops = {

     .read = stellaris_enet_read,

     .write = stellaris_enet_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static void stellaris_enet_reset(DeviceState *dev)

-- 

1.8.3.1

​

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel