[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] tools/tests/cpu-policy: disable -Wformat-overflow

On 09.08.2019 12:41, Ian Jackson wrote:
Marek Marczykowski-Górecki writes ("[PATCH 2/2] tools/tests/cpu-policy: disable 
GCC9 complains about "%.12s" format with an argument having exactly 12
bytes and no terminating null character. This is intentional
construct, so disable the warning.

Is there some good reason to have things done this way ?
ISTM that a nicer fix would be to change 12 to 13, earlier.
That way we wouldn't lose justified -Wformat-overflow output.

Would you mind clarifying which 12 you mean to change to 13?
The one in "%.12s" would, if changed and afaict, then
legitimately trigger the warning. And we've already objected
to the array to get grown.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.