Re: [Xen-devel] [PATCH 2/2] tools/tests/cpu-policy: disable -Wformat-overflow

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Marek Marczykowski-Górecki writes ("[PATCH 2/2] tools/tests/cpu-policy: disable 
-Wformat-overflow"):
> GCC9 complains about "%.12s" format with an argument having exactly 12
> bytes and no terminating null character. This is intentional
> construct, so disable the warning.

Is there some good reason to have things done this way ?
ISTM that a nicer fix would be to change 12 to 13, earlier.
That way we wouldn't lose justified -Wformat-overflow output.

I appreciate this is only a test program so I'm bikeshedding rather.

As an aside, I hope this code is compiled with -fno-strict-aliasing,
because otherwise it's definitely type-punning in a UB way.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel