[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 1/4] xen/spinlocks: in debug builds store cpu holding the lock
- To: Julien Grall <julien.grall@xxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Thu, 8 Aug 2019 11:52:34 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BN6DNjHLLaWMvwBzNZ6gItoQlKVofn0rb+5eCMBobsU=; b=bcoCiEQ3qrLEMRmuLXOTjaguOC+ipCCVFQIeiljKMKekzM70Veu39ZCFzDgokDxey5ZLhrRu8NGLDob6HvW3fwQROFfJMIS7tW8JNQRRRibWieFIlEffXF0fHzN6vb6PgddNzL51hg8Ihf0KeuaQ5ChXElvixnG93h7cOlSk3iGhA8Hist4xp+Ns5m3aZatyayiqxgsARo6ppj+GKGkx6vVzVcgtWnTC+fCgRTIlPv1KhvdfYNhRAXRlhdQ3x3TiLBK17hmvHxffV3GcYIMFZciGFUeTWT48nJQ2LG9ktJaKQ2TdPFzTJYjxGSsxwccNlYreEeR8iQjVlceNG1KFiA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O8sx9czkqB22rMtTdlflC4UOVtWVJF0wFXTbSDnXFheutEENawNQwM0Cg3ok8gqN5kj2TnN/XeC6E0/Rpa09s0plsulI24KBzFmeU99089gjW1lfNwHZucXEp6dFrf3mmLExfkee7ZtZb/0LwJgMG7G4QB7SroSjmrNmPEO1+bRtdnSiGvyA0OkRgCTJLn/o1tVFBUZDbfG4iWvNt7/BJ320KGptIzRNXlMbDL1TijNF/Ud50eBs6BXmOACXNw4KIuMas3EvA5PhLwzIPVe2plO7ko12nUBFx5Dr82yaph9v69rRtF0zytw2ZqiMNQHGjQ2CjlGdUnIFpZj1cqHULg==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Juergen Gross <JGross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 08 Aug 2019 11:54:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVTSzXlrQ8kurvmUW1rudnDuQmCKbw9GCA///tid6AACvj3YAAF10A
- Thread-topic: [PATCH 1/4] xen/spinlocks: in debug builds store cpu holding the lock
On 08.08.2019 12:28, Julien Grall wrote:
> On 08/08/2019 08:51, Juergen Gross wrote:
>> On 08.08.19 08:58, Jan Beulich wrote:
>>> On 07.08.2019 16:31, Juergen Gross wrote:
>>> Do we have an implied assumption somewhere that unsigned short is
>>> exactly 16 bits wide? I think "val" wants to be uint16_t here (as
>>> you really mean "exactly 16 bits"), the two boolean fields want
>>> to be bool, and the remaining two ones unsigned int.
>>
>> But that would increase the size of the union to 4 bytes instead of 2.
>> So at least pad and cpu must be unsigned short or (better) uint16_t.
>
> How about bool irq_safe:1?
That's what I had suggested, indeed. Jürgen's response was for
my "unsigned int" suggestion towards the two non-boolean fields.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
